Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitChunksPlugin blows up without options object #6644

Closed
zacanger opened this issue Mar 1, 2018 · 1 comment · Fixed by #6645
Closed

SplitChunksPlugin blows up without options object #6644

zacanger opened this issue Mar 1, 2018 · 1 comment · Fixed by #6645

Comments

@zacanger
Copy link
Contributor

zacanger commented Mar 1, 2018 •
edited

Do you want to request a feature or report a bug?

Bug.

What is the current behavior?

SplitChunksPlugin blows up without options object, but proposed docs suggest options are optional.

If the current behavior is a bug, please provide the steps to reproduce.

Include webpack.optimize.SplitChunksPlugin() in your plugins and run Webpack -- it blows up. Add an empty object {} and it's fine.

What is the expected behavior?

It probably shouldn't blow up. A change here (static normalizeOptions (options = {}) { is all it would take.

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.

Node 8.9.4, Webpack 4.0.1.
@montogeek
Copy link
Member

Send a PR

@zacanger zacanger mentioned this issue Mar 2, 2018
Merged
sokra added a commit that referenced this issue Mar 3, 2018
@sokra
Merge pull request #6645 from zacanger/fix/6644
00f70fc 
Fix #6644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6644
2 participants
@montogeek @zacanger