Fix #6644 #6645
Merged
Fix #6644 #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
requested changes
Mar 2, 2018
| const SplitChunksPlugin = require("../../../../lib/optimize/SplitChunksPlugin"); | ||
|
|
||
| module.exports = { | ||
| entry: { |
There was a problem hiding this comment.
Please set optimization.splitChunks=false
|
@zacanger Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ooflorent Please review the new changes. |
sokra
approved these changes
Mar 3, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #6644 by adding a default parameter.
Did you add tests for your changes?
Yes.
If relevant, link to documentation update:
https://github.com/webpack/webpack.js.org/pull/1863/files#diff-e08b426c523b9305ce571576d5b640d0R19
Summary
See #6644
Does this PR introduce a breaking change?
No.
Other information