Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/README update #7424

Closed
keblodev opened this issue May 29, 2018 · 1 comment
Closed

test/README update #7424

keblodev opened this issue May 29, 2018 · 1 comment

Comments

@keblodev
Copy link
Member

Feature request

Seems like use case of expected.txt + actual.txt described int test/README is outdated and jest's toMatchSnapshot() is being used

  • I would want to update the relevant info in README to avoid confusion

  • remove accept-stats.js as it's not being used anywhere anymore

What is the expected behavior?

updated test/README related to StatsTestCases.test.js with jest's toMatchSnapshot() info and flow and unused test module to be removed

What is motivation or use case for adding/changing the behavior?

How should this be implemented in your opinion?

Are you willing to work on this yourself?
yes

@ooflorent
Copy link
Member

Send a PR

keblodev added a commit to keblodev/webpack that referenced this issue May 29, 2018
keblodev added a commit to keblodev/webpack that referenced this issue May 29, 2018
keblodev added a commit to keblodev/webpack that referenced this issue May 29, 2018
keblodev added a commit to keblodev/webpack that referenced this issue May 29, 2018
sokra added a commit that referenced this issue May 29, 2018
Issue #7424:  test/README update with jest snapshot flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants