Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7424: test/README update with jest snapshot flow #7427

Merged
merged 1 commit into from
May 29, 2018

Conversation

keblodev
Copy link
Member

Update according to #7424

What kind of change does this PR introduce?

  • Updating test/Readme with jest snapshot approach
  • Removed unused test module

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@webpack-bot
Copy link
Contributor

webpack-bot commented May 29, 2018

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

@ronanamsterdam Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@keblodev keblodev force-pushed the feature/test-readme-update branch from 862c0e9 to 5705713 Compare May 29, 2018 10:54
@keblodev
Copy link
Member Author

spotted few misleading typos there. PR updated

@sokra sokra merged commit bfdb769 into webpack:master May 29, 2018
@sokra
Copy link
Member

sokra commented May 29, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants