Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit errors for exports in commonjs modules for which we know that they don't exist #12027

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 19, 2020

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
a bugfix. previously such imports were incorrectly accepted

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra force-pushed the bugfix/non-existing-export-warning-error branch from 2d6505a to 8aecb1f Compare November 19, 2020 11:15
@sokra sokra merged commit 51eba1f into master Nov 19, 2020
@sokra sokra deleted the bugfix/non-existing-export-warning-error branch November 19, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants