Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the verb "to need" for the singular form "he", "she" & "it": lacking the "s" at "it needs" #18414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patacra
Copy link

@patacra patacra commented May 21, 2024

Hi,

I know that it has nothing to do with coding and the way this powerful bundler works, but I was just reading the comments in some of my bundled JS files and noticed that the verb "to need" was often missing a "s" for the singular form "he needs" or "it needs to ...".

Typical example: "This entry need to be wrapped in an IIFE because it need to be in strict mode."

Conjugation of the verb "to need": https://www.theconjugator.com/english/verb/to+need.html

I effectively notice that some online dictionaries do not detect the mistake if the subject isn't the word "he", "she" or "it".
So "This salad needs to be washed before eating it" would be correct, but if you remove the "s", some dictionaries won't necessarily see the mistake. Or perhaps I'm totally wrong, and some new English rules allow removing the "s" in some situations?

Patrick Janser and others added 2 commits May 21, 2024 13:49
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link

linux-foundation-easycla bot commented May 21, 2024

CLA Missing ID CLA Not Signed

@alexander-akait
Copy link
Member

Please accept CLA, thank you

@webpack-bot
Copy link
Contributor

Hi @patacra.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own main branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

@patacra
Copy link
Author

patacra commented May 22, 2024

Please accept CLA, thank you

Thanks @alexander-akait for the suggestion, but I unfortunately didn't manage to get it done. I signed both PDFs, by also creating the cadwork company (my employer), even if this pull request has nothing to do with my employer.

But nevermind, this correction was just a suggestion, as it's just an English error and not a bug at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants