Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the verb "to need" for the singular form "he", "she" & "it": lacking the "s" at "it needs" #18414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion declarations/WebpackOptions.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2368,7 +2368,7 @@ export interface PerformanceOptions {
*/
export interface SnapshotOptions {
/**
* Options for snapshotting build dependencies to determine if the whole cache need to be invalidated.
* Options for snapshotting build dependencies to determine if the whole cache needs to be invalidated.
*/
buildDependencies?: {
/**
Expand Down
2 changes: 1 addition & 1 deletion examples/asset-advanced/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ module.exports = "data:image/svg+xml,%3csvg xmlns='http://www.w3.or...3c/svg%3e"

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/asset-simple/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ module.exports = "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDo...vc3ZnPgo="

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/cjs-tree-shaking/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ __webpack_unused_export__ = function multiply() {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/code-splitting-bundle-loader/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ __webpack_require__.e(/*! require.ensure */ 929).then((function(require) {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/code-splitting-harmony/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ module.exports = webpackAsyncContext;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be in strict mode.
// This entry needs to be wrapped in an IIFE because it needs to be in strict mode.
(() => {
"use strict";
/*!********************!*\
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ module.exports = webpackAsyncContext;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/code-splitting-native-import-context/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ module.exports = webpackAsyncContext;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/code-splitting-specify-chunk-name/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ module.exports = webpackAsyncContext;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/code-splitting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ require.ensure(["c"], function(require) {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/coffee-script/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ module.exports = 42;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/commonjs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ exports.add = function() {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/css/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ module.exports = __webpack_require__.p + "89a353e9c515885abd8e.png";

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-json-modules/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ module.exports = JSON.parse('{"title":"JSON5 Example","owner":{"name":"Tom Prest

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/dll-app-and-vendor/1-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ module.exports = vendor_lib_bef1463383efb1c65306;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be in strict mode.
// This entry needs to be wrapped in an IIFE because it needs to be in strict mode.
(() => {
"use strict";
/*!************************!*\
Expand Down
2 changes: 1 addition & 1 deletion examples/dll-user/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ module.exports = (__webpack_require__(/*! dll-reference alpha_a53f6ab3ecd4de1831

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/externals/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ module.exports = __WEBPACK_EXTERNAL_MODULE__2__;

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
var exports = __webpack_exports__;
/*!********************!*\
Expand Down
2 changes: 1 addition & 1 deletion examples/harmony-interop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ var named = "named";

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be in strict mode.
// This entry needs to be wrapped in an IIFE because it needs to be in strict mode.
(() => {
"use strict";
/*!********************!*\
Expand Down
2 changes: 1 addition & 1 deletion examples/harmony-unused/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ function c() { console.log("c"); }

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/harmony/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ function add() {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/loader/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ module.exports = function (cssWithMappingToString) {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/mixed/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ __webpack_require__.r(__webpack_exports__);

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/module-federation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ import React from "react";
import { formatRelative, subDays } from "date-fns";
// date-fns is a shared module, but used as usual
// exposing modules act as async boundary,
// so no additional async boundary need to be added here
// so no additional async boundary needs to be added here
// As data-fns is an shared module, it will be placed in a separate file
// It will be loaded in parallel to the code of this module

Expand Down
2 changes: 1 addition & 1 deletion examples/module-federation/src-b/Component.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from "react";
import { formatRelative, subDays } from "date-fns";
// date-fns is a shared module, but used as usual
// exposing modules act as async boundary,
// so no additional async boundary need to be added here
// so no additional async boundary needs to be added here
// As data-fns is an shared module, it will be placed in a separate file
// It will be loaded in parallel to the code of this module

Expand Down
2 changes: 1 addition & 1 deletion examples/multi-compiler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ console.log("Running " + "desktop" + " build");

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/named-chunks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ require.ensure(["b"], function(require) {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/require.context/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ module.exports = function() {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/scope-hoisting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ var x = "x";

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************************!*\
!*** ./example.js + 2 modules ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/side-effects/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ const b = "b";

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/top-level-await/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ const AlternativeCreateUserAction = async name => {

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ console.log(getArray(1, 2, 3));

``` js
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
// This entry needs to be wrapped in an IIFE because it needs to be isolated against other modules in the chunk.
(() => {
/*!********************!*\
!*** ./example.js ***!
Expand Down
2 changes: 1 addition & 1 deletion lib/asset/AssetGenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ class AssetGenerator extends Generator {
module.buildInfo.assetInfo = assetInfo;
if (getData) {
// Due to code generation caching module.buildInfo.XXX can't used to store such information
// It need to be stored in the code generation results instead, where it's cached too
// It needs to be stored in the code generation results instead, where it's cached too
// TODO webpack 6 For back-compat reasons we also store in on module.buildInfo
const data = getData();
data.set("fullContentHash", fullHash);
Expand Down
6 changes: 3 additions & 3 deletions lib/buildChunkGraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ const visitModules = (
}
}
// pop() is used to read from the queue
// so it need to be reversed to be iterated in
// so it needs to be reversed to be iterated in
// correct order
queue.reverse();

Expand Down Expand Up @@ -641,7 +641,7 @@ const visitModules = (
}
connectList.add(/** @type {ChunkGroupInfo} */ (cgi));

// TODO check if this really need to be done for each traversal
// TODO check if this really needs to be done for each traversal
// or if it is enough when it's queued when created
// 4. We enqueue the DependenciesBlock for traversal
queueDelayed.push({
Expand Down Expand Up @@ -670,7 +670,7 @@ const visitModules = (
const minAvailableModules =
/** @type {bigint} */
(chunkGroupInfo.minAvailableModules);
// Buffer items because order need to be reversed to get indices correct
// Buffer items because order needs to be reversed to get indices correct
// Traverse all referenced modules
for (let i = 0, len = blockModules.length; i < len; i += 3) {
const refModule = /** @type {Module} */ (blockModules[i]);
Expand Down
2 changes: 1 addition & 1 deletion lib/javascript/EnableChunkLoadingPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class EnableChunkLoadingPlugin {
if (!getEnabledTypes(compiler).has(type)) {
throw new Error(
`Chunk loading type "${type}" is not enabled. ` +
"EnableChunkLoadingPlugin need to be used to enable this type of chunk loading. " +
"EnableChunkLoadingPlugin needs to be used to enable this type of chunk loading. " +
'This usually happens through the "output.enabledChunkLoadingTypes" option. ' +
'If you are using a function as entry which sets "chunkLoading", you need to add all potential chunk loading types to "output.enabledChunkLoadingTypes". ' +
"These types are enabled: " +
Expand Down
6 changes: 3 additions & 3 deletions lib/javascript/JavascriptModulesPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -845,18 +845,18 @@ class JavascriptModulesPlugin {
const webpackExports =
exports && m.exportsArgument === RuntimeGlobals.exports;
let iife = innerStrict
? "it need to be in strict mode."
? "it needs to be in strict mode."
: inlinedModules.size > 1
? // TODO check globals and top-level declarations of other entries and chunk modules
// to make a better decision
"it need to be isolated against other entry modules."
"it needs to be isolated against other entry modules."
: exports && !webpackExports
? `it uses a non-standard name for the exports (${m.exportsArgument}).`
: hooks.embedInRuntimeBailout.call(m, renderContext);
let footer;
if (iife !== undefined) {
startupSource.add(
`// This entry need to be wrapped in an IIFE because ${iife}\n`
`// This entry needs to be wrapped in an IIFE because ${iife}\n`
);
const arrow = runtimeTemplate.supportsArrowFunction();
if (arrow) {
Expand Down
2 changes: 1 addition & 1 deletion lib/sharing/ConsumeSharedPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ class ConsumeSharedPlugin {
);
if (typeof requiredVersion !== "string") {
requiredVersionWarning(
`Unable to find required version for "${packageName}" in description file (${descriptionPath}). It need to be in dependencies, devDependencies or peerDependencies.`
`Unable to find required version for "${packageName}" in description file (${descriptionPath}). It needs to be in dependencies, devDependencies or peerDependencies.`
);
return resolve();
}
Expand Down
2 changes: 1 addition & 1 deletion lib/util/deterministicGrouping.js
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ module.exports = ({ maxSize, minSize, items, getSize, getKey }) => {

// find unsplittable area from left and right
// going minSize from left and right
// at least one node need to be included otherwise we get stuck
// at least one node needs to be included otherwise we get stuck
let left = 1;
let leftSize = Object.create(null);
addSizeTo(leftSize, group.nodes[0].size);
Expand Down
2 changes: 1 addition & 1 deletion lib/wasm/EnableWasmLoadingPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class EnableWasmLoadingPlugin {
if (!getEnabledTypes(compiler).has(type)) {
throw new Error(
`Library type "${type}" is not enabled. ` +
"EnableWasmLoadingPlugin need to be used to enable this type of wasm loading. " +
"EnableWasmLoadingPlugin needs to be used to enable this type of wasm loading. " +
'This usually happens through the "output.enabledWasmLoadingTypes" option. ' +
'If you are using a function as entry which sets "wasmLoading", you need to add all potential library types to "output.enabledWasmLoadingTypes". ' +
"These types are enabled: " +
Expand Down
4 changes: 2 additions & 2 deletions open-bot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ rules:
* [ ] <!-- document --> This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
* [ ] <!-- webpack-4-backport --> This needs to be backported to webpack 4 (issue will be created when merged)

# When a pull request need to be documented, create an issue in webpack/webpack.js.org when merged
# When a pull request needs to be documented, create an issue in webpack/webpack.js.org when merged
- filters:
pull_request:
merged: true
Expand Down Expand Up @@ -294,7 +294,7 @@ rules:
message: |-
I've created an issue to document this in webpack/webpack.js.org.

# When a pull request need to be backported, create an issue in webpack/webpack when merged
# When a pull request needs to be backported, create an issue in webpack/webpack when merged
- filters:
pull_request:
merged: true
Expand Down
2 changes: 1 addition & 1 deletion schemas/WebpackOptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -4670,7 +4670,7 @@
"additionalProperties": false,
"properties": {
"buildDependencies": {
"description": "Options for snapshotting build dependencies to determine if the whole cache need to be invalidated.",
"description": "Options for snapshotting build dependencies to determine if the whole cache needs to be invalidated.",
"type": "object",
"additionalProperties": false,
"properties": {
Expand Down
Loading
Loading