Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example): update examples template #3074

Merged
merged 2 commits into from
Sep 29, 2016
Merged

docs(example): update examples template #3074

merged 2 commits into from
Sep 29, 2016

Conversation

zhaoshengjun
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    This should fix issue example error #3050 . Update examples to 2.1.0-beta.25.

What is the current behavior? (You can also link to an open issue here)
Run buildAll.js will fail on some examples.

What is the new behavior?
Run buildAll.js will success.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

@TheLarkInn
Copy link
Member

TheLarkInn commented Sep 28, 2016

@zhaoshengjun what is the level of effort to make the buildAll.js script executable and convert to a npm script like: (this is not related to PR but now that you have experience running it)

npm run build:examples

@zhaoshengjun
Copy link
Contributor Author

It will take less than a minute (literally) to add such a script.:smile:

Is this another PR?

@TheLarkInn
Copy link
Member

I'll accept in the same PR. Just want to make it easier for us to build these from the npm scripts section.

@zhaoshengjun
Copy link
Contributor Author

Done!

@TheLarkInn TheLarkInn merged commit 557d4af into webpack:master Sep 29, 2016
@TheLarkInn
Copy link
Member

Thank you so much.

amsdamsgram added a commit to amsdamsgram/webpack that referenced this pull request Oct 6, 2016
* master: (77 commits)
  remove-automatic-loader-extension: update examples
  fix-2986: Remove automatic -loader module name extension
  replaced calls to Object.assign with objectAssign to support node 0.12.x (webpack#3080)
  docs(example): update examples template (webpack#3074)
  Fix plugin typos in options validation
  feat(readme): add jsbeautify-loader to readme (webpack#3062)
  Update loader utils dependency to fix webpack#3060
  add number for schema info
  2.1.0-beta.25
  fix test
  fixed Validation message
  fixed dll test cases
  fixed browsertest
  added a note about applying the LoaderOptionsPlugin only for some modules
  added another custom error message for the debug property
  Adds empty into schema for node (webpack#3034)
  Moving parsing of the `progress` flag to webpack specific bin
  2.1.0-beta.24
  beautify
  fixed max line length
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants