replaced calls to Object.assign with objectAssign to support node 0.12.x #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. |
|
@theLarkin merge it. Can't merge from phone. A test for |
|
@MarkusKramer would you be willing to write the test for this? Otherwise make an issue for the test and I'll merge. |
|
Sorry, I know next to nothing about these three modules and don't feel that I could write a test for them. to increase test coverage ;-) (jocking) @TheLarkInn I've created issue #3081 |
amsdamsgram
added a commit
to amsdamsgram/webpack
that referenced
this pull request
Oct 6, 2016
* master: (77 commits) remove-automatic-loader-extension: update examples fix-2986: Remove automatic -loader module name extension replaced calls to Object.assign with objectAssign to support node 0.12.x (webpack#3080) docs(example): update examples template (webpack#3074) Fix plugin typos in options validation feat(readme): add jsbeautify-loader to readme (webpack#3062) Update loader utils dependency to fix webpack#3060 add number for schema info 2.1.0-beta.25 fix test fixed Validation message fixed dll test cases fixed browsertest added a note about applying the LoaderOptionsPlugin only for some modules added another custom error message for the debug property Adds empty into schema for node (webpack#3034) Moving parsing of the `progress` flag to webpack specific bin 2.1.0-beta.24 beautify fixed max line length ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior?
Issue #3041. With node 0.12.x it fails with
Does this PR introduce a breaking change?