refactor(es6): refactor PrefetchPlugin to ES6 class #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hiroppy
reviewed
Jan 1, 2017
| }); | ||
| compiler.plugin("make", (compilation, callback) => { | ||
| compilation.prefetch(this.context || compiler.context, new PrefetchDependency(this.request), callback); | ||
| }.bind(this)); |
There was a problem hiding this comment.
I think bind(this) is unnecessary.
forgot to take out the params at the top of the class
Jessidhia
suggested changes
Jan 1, 2017
| class PrefetchPlugin { | ||
|
|
||
| constructor(context, request) { | ||
| if(!this.request) { |
There was a problem hiding this comment.
@Kovensky What was your procedure to check?
There was a problem hiding this comment.
Nothing, really; I just noticed while reading the code.
Looking at the original also shows it was request instead of this.request :)
There was a problem hiding this comment.
I made my first commit at 4AM :-) May be why! Thank you
|
Thanks. Congrats on first PR. :-D 😍 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor (ES5 => ES6)
Did you add tests for your changes?
No functionality was edited. Tested with webpack@2.2.0-rc.3!
If relevant, link to documentation update:
N/A
Summary
This is my first OSS contribution ever. Saw that this dependency needed some ES6 care... so I gave it some.
Does this PR introduce a breaking change?
Nope.