fix(node): rollback changes of Buffer.from to new Buffer() #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own travis to 4.3 min node v
egoroof
reviewed
Jan 17, 2017
| @@ -65,7 +65,7 @@ | |||
| "worker-loader": "~0.7.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=4.7.0 <5.0.0 || >=5.10" | |||
| "node": ">=4.3.0 <5.0.0 || >=5.10" | |||
There was a problem hiding this comment.
Change the line to just "node": ">=4.3.0"
There was a problem hiding this comment.
We still don't want to support node 5 though?
| @@ -408,6 +408,10 @@ buffer-shims@^1.0.0: | |||
| version "1.0.0" | |||
| resolved "https://registry.yarnpkg.com/buffer-shims/-/buffer-shims-1.0.0.tgz#9978ce317388c649ad8793028c3477ef044a8b51" | |||
|
|
|||
| buffer-v6-polyfill@^1.0.3: | |||
There was a problem hiding this comment.
Why is buffer-v6-polyfill necessary if you change Buffer.from to new Buffer?
There was a problem hiding this comment.
This will get de committed
There was a problem hiding this comment.
Didn't been to check-in in lock for
sokra
approved these changes
Jan 17, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
N/A
If relevant, link to documentation update:
N/A
Summary
Because AWS Lambda (see #3984) is only supporting node 4.3 😦 as their max version, this PR rollsback use of
Buffer.fromin favor of the cross version supportednew Buffer. It is deprecated for the future, but currently, warnings nor errors will emit from use ofnew Buffereven in Node 7@latest. To ensure that this is testing accurately, I've bumped our CI version for node down to 4.3 on travis as well and updated the engine field in ourpackage.jsonDoes this PR introduce a breaking change?
No
Other information
Fixed #3984