ES6 refactoring in DependenciesBlock and Module #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not add/change any code logic, but @webpack-bot tells me |
|
@smelukov This message is based on Code Coverage :) ( |
|
It looks like this Pull Request doesn't include enough test cases. @smelukov Please add more test cases. See test readme for details how to write test cases. |
|
The minimum test ratio has been reached. Thanks! |
|
The most important CI builds succeeded. Great work so far. |
|
The Code Coverage for the code you refactored was low before, so if you touch it codecov reports also low coverage for your PR. For the ES6 refactoring PRs that's fine for me. But thanks for adding test cases 😄. Bot seem to have a positive effect 🎉. |
sokra
approved these changes
Apr 4, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring of Webpack Core
Did you add tests for your changes?
Yes
Summary
More ES6 code in Webpack Core (
DependenciesBlockandModule)Inspired #4099
Does this PR introduce a breaking change?
No