ES6 refactoring in NormalModuleFactory #4633

smelukov · 2017-04-03T21:29:19Z

What kind of change does this PR introduce?

Refactoring of Webpack Core

Did you add tests for your changes?

No, all current tests still pass

Summary

More ES6 code in Webpack Core (NormalModuleFactory)

Inspired #4099

Does this PR introduce a breaking change?

No

sokra

Looks good except one thing:

Replace let with const where possible

webpack-bot · 2017-04-04T08:27:53Z

@smelukov Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

webpack-bot · 2017-04-04T08:47:05Z

The most important CI builds succeeded. Great work so far.

sokra · 2017-04-04T08:51:48Z

Thanks

ES6 refactoring in NormalModuleFactory

7c4883c

webpack-bot added PR: unreviewed PR: CI-ok labels Apr 3, 2017

sokra requested changes Apr 4, 2017

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Apr 4, 2017

let to const in NormalModuleFactory

3ebcf71

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Apr 4, 2017

webpack-bot added the mentioned-sokra label Apr 4, 2017

sokra approved these changes Apr 4, 2017

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 4, 2017

sokra merged commit be8e1b3 into webpack:master Apr 4, 2017

smelukov deleted the refactor-normal-module-factory branch April 4, 2017 08:54

Provide feedback