add safe (persistent) resolver cache #8273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
This comment has been minimized.
This comment has been minimized.
sokra
force-pushed
the
feature/resolve-cache
branch
from
fdcb229
to
2688b5b
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
remove unsafe resolve cache remainings
sokra
force-pushed
the
feature/resolve-cache
branch
from
2498d82
to
3b35fd4
Compare
sokra
force-pushed
the
feature/resolve-cache
branch
from
d19c06e
to
02ba24a
Compare
montogeek
reviewed
Nov 3, 2018
| @@ -0,0 +1,260 @@ | |||
| /* | |||
There was a problem hiding this comment.
Why the indentation is 8 spaces only in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the unsafe resolver cache with a safe (re-validated) resolver cache which uses the (persistent) caching infrastructure.
As this stores many small cache entries it should be used with packed filesystem store mode. #8272
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
existing tests
Does this PR introduce a breaking change?
yes
What needs to be documented once your changes are merged?
nothing