Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce should not prevent using minChunks etc. on cacheGroup #8466

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 5, 2018

Partial revert "enforce doesn't affect minSize for maxSize" #8451

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
It reverts an accidental breaking introduces by #8451

What needs to be documented once your changes are merged?
The splitChunks.enforce documentation is incorrect.
It should be stated that enforce sets minChunks: 1, minSize: 0 and maxInitial/AsyncRequests: Infinity, but it's supported that this can be overriden by the same property on the cacheGroup

Partial revert "enforce doesn't affect minSize for maxSize"
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit f29ca64 into master Dec 5, 2018
@sokra sokra deleted the bugfix/splitChunks-enforce branch December 5, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants