Skip to content

enforce doesn't affect minSize for maxSize#8451

Merged
sokra merged 1 commit intomasterfrom
bugfix/split-chunks
Dec 3, 2018
Merged

enforce doesn't affect minSize for maxSize#8451
sokra merged 1 commit intomasterfrom
bugfix/split-chunks

Conversation

@sokra
Copy link
Copy Markdown
Member

@sokra sokra commented Dec 3, 2018

enforce now works as documented
emit warning for minSize > maxSize configuration
performance improvements
bugfix when multiple cacheGroups have the same name

fixes #8407

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
yes, but a bugfix

What needs to be documented once your changes are merged?
enforce now works as documented.

Tells webpack to ignore splitChunks.minSize, splitChunks.maxSize, splitChunks.minChunks, splitChunks.maxAsyncRequests and splitChunks.maxInitialRequests options and always create chunks for this cache group.

But there is a little error in the documentation as splitChunks.maxSize is not ignored.

Tells webpack to ignore splitChunks.minSize, splitChunks.minChunks, splitChunks.maxAsyncRequests and splitChunks.maxInitialRequests options and always create chunks for this cache group.

enforce now works as documented
emit warning for minSize > maxSize configuration
performance improvements
bugfix when multiple cacheGroups have the same name

fixes #8407
@webpack-bot
Copy link
Copy Markdown
Contributor

webpack-bot commented Dec 3, 2018

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Copy Markdown
Contributor

I've created an issue to document this in webpack/webpack.js.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimization.splitChunks.maxSize throws error or causes build to hang

2 participants