Optimize performance of chunk graph generation #9472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor chunk graph generation to include available modules optimization
We can't disable it in production yet, as this could be a breaking change.
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring adds available modules tracking to the chunk graph generation. This allows to skip a lot of modules in async chunks when modules are already used in all parents. This improves performance when many chunks are used.
Related issues:
#9460
#8644
What kind of change does this PR introduce?
refactoring, performance
Did you add tests for your changes?
existing tests
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
optimization.removeAvailableModulesis no longer recommended, as a similar optimization is included in the chunk graph building. It might still make sense when chunks are merged i. e. with thesplitChunksand a constantname.