This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
should support top level array for templates when not a collection #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ var generate = function(req, res, next) { | |||
|
|
|||
| } else { | |||
|
|
|||
| var size = typeof service.size === 'function' ? service.size.apply(service, [params, query, body, cookies]) : service.size; | |||
| var size = _.isFunction(service.size) ? service.size.apply(service, [params, query, body, cookies]) : service.size; | |||
There was a problem hiding this comment.
this change is not related to the actual feature PR, but it was just to stick to the lodash test pattern.
|
Thanks @Mortimerp9! Just released as v0.4.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we want to "hardcode" a collection, the toplevel value of
templateis an array. However,Object.createwill not make the right prototype and only return a bar object. We want to make sure to get an array back at the end.