TSV-ART review from Magnus Westerlund #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Oct 5, 2016
| </t> | ||
| </list> | ||
|
|
||
| Where HTTP/2 server push is required, the more verbose frame format |
There was a problem hiding this comment.
Some IETF curmudgeons will get their panties in a twist over "required", since "REQUIRED" is an RFC 2119 keyword. I tend to avoid it to avoid the pedants.
| A recipient parsing and converting a TTL value to binary form SHOULD use an | ||
| arithmetic type of at least 31 bits of non-negative integer range. If a recipient | ||
| receives a TTL value greater than the greatest integer it can represent, or if any | ||
| of its subsequent calculations overflows, it MUST consider the value to be 2147483648 (2^31). |
There was a problem hiding this comment.
I couldn't find where you cribbed this text from. It looks fine.
gloinul
reviewed
Oct 5, 2016
| <t> | ||
| To limit the number of stored push messages, the push service MAY respond with a shorter | ||
| Time-To-Live than proposed by the application server in its request for push message delivery | ||
| (<xref target="ttl"/>). Once a message has been accepted, the push service MAY later expire | ||
| the message prior to its advertised Time-To-Live. If the application server requested a | ||
| delivery receipt, the push service MUST return a failure response (<xref target="acknowledge_message"/>). | ||
| delivery receipt, the push service MUST return a failure response (s<xref target="acknowledge_message"/>). |
There was a problem hiding this comment.
Is that "s" in the parenthesis spurious?
There was a problem hiding this comment.
Doh. Yes. I was editing out a see and managed to miss the s. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft attempts to address all of the issues identified during TSV-ART review with the exception of Dealing with overload situations where further guidance has been requested from early implementers of webpush.