Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSV-ART review from Magnus Westerlund #131

Merged
merged 6 commits into from
Oct 5, 2016
Merged

TSV-ART review from Magnus Westerlund #131

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
890ca7b
Section 3
Oct 4, 2016
6ac5dea
Section 5.2
Oct 4, 2016
23353fa
Section 7.2
Oct 4, 2016
91ca701
Unclarities which requests that require HTTP/2
Oct 4, 2016
c9db4f7
Avoid the use of required (Martin)
Oct 5, 2016
332f3fd
editorial
Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 33 additions & 4 deletions draft-ietf-webpush-protocol.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,37 @@
<t>
Examples in this document use the <xref target="RFC7230">HTTP/1.1
message format</xref>. Many of the exchanges can be completed using
HTTP/1.1. Where HTTP/2 is necessary, the more verbose frame format
from <xref target="RFC7540"/> is used.
HTTP/1.1:

<list style="symbols">
<t>
<xref target="message_subscription">Subscribing for Push Messages</xref>
</t>
<t>
<xref target="send">Requesting Push Message Delivery</xref>
</t>
<t>
<xref target="replace">Replacing Push Messages</xref>
</t>
<t>
<xref target="acknowledge_message">Acknowledging Push Messages</xref>
</t>
</list>

Where HTTP/2 server push is required, the more verbose frame format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some IETF curmudgeons will get their panties in a twist over "required", since "REQUIRED" is an RFC 2119 keyword. I tend to avoid it to avoid the pedants.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound advice. Updated.

from <xref target="RFC7540"/> is used:

<list style="symbols">
<t>
<xref target="monitor-subscription">Receiving Push Messages for a Subscription</xref>
</t>
<t>
<xref target="monitor-set">Receiving Push Messages for a Subscription Set</xref>
</t>
<t>
<xref target="receive_receipt">Receiving Push Message Receipts</xref>
</t>
</list>
</t>
<t>
Examples do not include specific methods for push message encryption
Expand Down Expand Up @@ -1075,13 +1104,13 @@ HEADERS [stream 82] +END_STREAM
in response to requests that include an entity body that is too large.
Push services MUST NOT return a 413 status code in responses to an entity
body that is 4096 bytes or less in size.
</t>
</t>
<t>
To limit the number of stored push messages, the push service MAY respond with a shorter
Time-To-Live than proposed by the application server in its request for push message delivery
(<xref target="ttl"/>). Once a message has been accepted, the push service MAY later expire
the message prior to its advertised Time-To-Live. If the application server requested a
delivery receipt, the push service MUST return a failure response (<xref target="acknowledge_message"/>).
delivery receipt, the push service MUST return a failure response (s<xref target="acknowledge_message"/>).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that "s" in the parenthesis spurious?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh. Yes. I was editing out a see and managed to miss the s. Thanks.

</t>
</section>

Expand Down