Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session cookie expiration #61

Closed
thinxer opened this issue May 5, 2011 · 4 comments · Fixed by #527
Closed

Session cookie expiration #61

thinxer opened this issue May 5, 2011 · 4 comments · Fixed by #527
Assignees

Comments

@thinxer
Copy link

thinxer commented May 5, 2011

Again, on the session cookie, i'm requesting for a persistent cookie with expiration rather than cookies that expire on browser close.

There has been some old threads, however i didn't see the reason why this feature could not be added.

http://groups.google.com/group/webpy/browse_thread/thread/4a6631f8a35b8372

https://bugs.launchpad.net/webpy/+bug/305360

@ghost ghost assigned anandology May 5, 2011
@indeyets
Copy link

easy "in-project" fix:

class Session(web.session.Session):
    def _setcookie(self, session_id, expires='', **kw):
        if expires == '':
            expires = self._config.timeout

        super(Session, self)._setcookie(session_id, expires, **kw)

@thinxer
Copy link
Author

thinxer commented Aug 26, 2011

Yes it would work. But why not add a 'persistent' option just like this: https://bugs.launchpad.net/webpy/+bug/305360.
It would be much easier for beginners, yet not many lines of code for web.py.

@despens
Copy link

despens commented Sep 21, 2011

I just filed a new issue with the same request: #99

Please make it happen. :)

@despens
Copy link

despens commented Oct 25, 2011

I would love to see this change finally.

@thinxer thinxer closed this as completed Apr 18, 2019
iredmail added a commit that referenced this issue Sep 16, 2019
* Remove py2.3 support.
* Replace `attr in obj.keys()` by `attr in obj`.
* Set default cookie expire time to session timeout.
* Add support for SameSite cookie.

Fixes #521
Fixes #61 #99 #337
Fixes #409 #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants