Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue with insert returning query #649

Merged
merged 2 commits into from Jun 24, 2020

Conversation

anandology
Copy link
Member

Closes #648

The insert ... returning ... query was not getting commited to the db
due to a recent change.

Issue webpy#648
iredmail
iredmail previously approved these changes Jun 24, 2020
Copy link
Contributor

@iredmail iredmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandology
Copy link
Member Author

These black issues are really frustrating.

This test was getting blocked when tried without the fix in the previous
commit.

Issue webpy#648
@anandology
Copy link
Member Author

Fixed the black errors.

@iredmail iredmail merged commit b8e6eba into webpy:master Jun 24, 2020
@anandology anandology deleted the 648-insert-returning branch June 24, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query("insert... returning") fails to commit
2 participants