Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python2 code #664

Merged
merged 2 commits into from Jul 26, 2020
Merged

Remove python2 code #664

merged 2 commits into from Jul 26, 2020

Conversation

sunwire
Copy link
Contributor

@sunwire sunwire commented Jul 25, 2020

Because we only support python 3, checks for Python 2 are no longer necessary.

Copy link
Contributor

@iredmail iredmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Could you please fix the pep8 style issue according to GitHub Action result? Just add one more empty line. :)
https://github.com/webpy/webpy/pull/664/checks?check_run_id=910430744

@cclauss
Copy link
Contributor

cclauss commented Jul 25, 2020

You can automate this process with https://github.com/asottile/pyupgrade

@iredmail
Copy link
Contributor

You can automate this process with https://github.com/asottile/pyupgrade

@cclauss Thanks for sharing, i tried pyupgrade and it fixes many code style issue for my personal project. :)

@cclauss
Copy link
Contributor

cclauss commented Jul 26, 2020

./web/http.py:27:1: E302 expected 2 blank lines, found 1
def prefixurl(base=""):
^
1     E302 expected 2 blank lines, found 1

@sunwire
Copy link
Contributor Author

sunwire commented Jul 26, 2020

1     E302 expected 2 blank lines, found 1

The second commit fix it a6f563d
https://github.com/sunwire/webpy/blob/master/web/http.py#L27
I don't know why the check on github fails. Maybe because there are two commits not one.
flake8 running locally returns no errors.

@iredmail iredmail merged commit 1d1a590 into webpy:master Jul 26, 2020
@iredmail
Copy link
Contributor

Merged and passed all checks. Thanks for your contribution @sunwire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants