Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle both session file and directory. #681

Merged
merged 1 commit into from Oct 14, 2020
Merged

Handle both session file and directory. #681

merged 1 commit into from Oct 14, 2020

Conversation

iredmail
Copy link
Contributor

fixes #680

@iredmail iredmail mentioned this pull request Oct 13, 2020
Closed
cclauss
cclauss reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@iredmail iredmail requested a review from cclauss October 14, 2020 07:07
@iredmail
Copy link
Contributor Author

No idea why GitHub doesn't allow me to merge this PR with approval from one reviewer. :(

cclauss
cclauss approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea to require at least one positive review.

@iredmail iredmail merged commit 772f5b3 into webpy:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@anandology anandology Awaiting requested review from anandology

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NotADirectory Error
2 participants
@iredmail @cclauss