Fix session.py to allow suppression of the cookie #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are often endpoints/targets in your web.py app where you do not want to use sessions and most importantly, you do not want a Set-Cookie header sent with the response. The Set-Cookie header invalidates your Cache-Control directives when you are caching your responses with many CDNs. This PR allows you to do session.no_cookie=True in your handler to suppress the session cookie when you do not want it.
cclauss
reviewed
Aug 6, 2022
|
Instead of using |
|
yep, it could certainly be send_cookie = True with the two booleans reversed. I mean, it's only a 2 line patch so whatever you prefer as maintainers! |
|
Yes, please. Also please run the code thru psf/black so the tests pass. |
|
I'm sorry, I don't use psf/black and I have no idea why this is failing as the github error does not offer any indication why. I can't see anything wrong with the 3 lines of code in my patch with regards formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are often endpoints/targets in your web.py app where you do not want to use sessions and most importantly, you do not want a Set-Cookie header sent with the response. The Set-Cookie header invalidates your Cache-Control directives when you are caching your responses with many CDNs. This PR allows you to do session.no_cookie=True in your handler to suppress the session cookie when you do not want it.