Crawler Finished Time added to done list and improvements #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented the ability to specify screen shot dimensions via the SCREENSHOT_DIMENSIONS environment key improved the handling of out link collection in order to handle pages with 1k+ links present in the dom at a time switch to using ABCMeta and EventEmitterS in order to ensure we are not forcing a __dict__ on classes that do not opt in for one unified slots format and removed un-necessary ABC usage in intermediate abstract classes updated README with new environment variables
…ky iframe/frame usage
…order to be more clear about what it does when all_frames is true, previously manual_collection, keyword arg in collect_outlinks is true, both all frame and behavior out link collection occurs rather than one or the other added typing to BehaviorTabs __slots__ to make linting happy
ikreymer
reviewed
Apr 26, 2019
autobrowser/tabs/crawlerTab.py
Outdated
| @@ -165,7 +197,8 @@ def main_frame_getter(self) -> Frame: | |||
| exc_info=e, | |||
| ) | |||
|
|
|||
| self.logger.info(logged_method, "crawl loop task ended") | |||
| end_info = Helper.json_string(id=self.reqid, time=time.time()) | |||
There was a problem hiding this comment.
Suggested change
| end_info = Helper.json_string(id=self.reqid, time=time.time()) | |
| end_info = Helper.json_string(id=self.reqid, time=int(time.time())) |
Otherwise includes a long decimal for microseconds, don't really need that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented adding the time a crawler finishes fixes #44
implemented the ability to specify screen shot dimensions via the SCREENSHOT_DIMENSIONS environment key
improved the handling of out link collection in order to handle pages with 1k+ links present in the dom at a time
switch to using ABCMeta and EventEmitterS in order to ensure we are not forcing a dict on classes that do not opt in for one
unified slots format and removed un-necessary ABC usage in intermediate abstract classes
updated README with new environment variables