Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Icons are missing throughout the app (v1.9.7) #1676

Closed
Shrinks99 opened this issue Apr 15, 2024 · 1 comment · Fixed by #1680
Closed

[Bug]: Icons are missing throughout the app (v1.9.7) #1676

Shrinks99 opened this issue Apr 15, 2024 · 1 comment · Fixed by #1680
Assignees
@emma-sg
Labels
bug Something isn't working front end Requires front end dev work

Comments

@Shrinks99
Copy link
Member

Browsertrix Version

v1.9.7-4ec1266

What did you expect to happen? What happened instead?

On Beta all the icons are missing! Expected them to be there, but they're not!

Reproduction instructions

  1. Log in
  2. They're gone! This affects every page.

Screenshots / Video

Screenshot of the Browsertrix dashboard with no icons

Environment

No response

Additional details

From Ilya in chat:

very odd - somehow its dropping the /shoelace path now, but the icons are there
can confirm same issue on dev server for v1.9.7 or v1.9.6 tag, its trying to load from http://localhost:9870/js/assets/icons/door-open.svg instead of http://localhost:9870/shoelace/assets/icons/door-open.svg
using /js instead of /shoelace 🙁
maybe some dependency got messed up - hopefully there's a quick fix
@Shrinks99 Shrinks99 added bug Something isn't working front end Requires front end dev work labels Apr 15, 2024
@emma-sg emma-sg mentioned this issue Apr 15, 2024
Merged
@emma-sg emma-sg linked a pull request Apr 15, 2024 that will close this issue
Fix icons in 1.9.8 #1680
Merged
ikreymer pushed a commit that referenced this issue Apr 15, 2024
@emma-sg
Fix icons in 1.9.8 (#1680)
f76b83e 
Closes #1676.

Loads `sl-icon` synchronously to get correct base path when running
webpack-dev-server and in prod

Partially cherry-picked from 548261e by
@SuaYoo.
@ikreymer
Copy link
Member

Fixed and released in 1.9.8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emma-sg emma-sg

Labels
bug Something isn't working front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix icons in 1.9.8 webrecorder/browsertrix
3 participants
@ikreymer @Shrinks99 @emma-sg