Manually approve pages in QA review #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
frontend-qa-pages
branch
from
2ef3c43
to
58ed8fa
Compare
SuaYoo
force-pushed
the
frontend-qa-pages
branch
from
58ed8fa
to
0718227
Compare
SuaYoo
changed the title
emma-sg
requested changes
Mar 11, 2024
| ])} | ||
| </div> | ||
| <div | ||
| class="mx-1.5 flex h-8 flex-1 items-center justify-between rounded border bg-neutral-0 px-2 text-sm leading-none" |
There was a problem hiding this comment.
Suggested change
| class="mx-1.5 flex h-8 flex-1 items-center justify-between rounded border bg-neutral-0 px-2 text-sm leading-none" | |
| class="mx-1.5 flex h-8 min-w-0 flex-1 items-center justify-between rounded border bg-neutral-0 px-2 text-sm leading-none" |
| <div | ||
| class="mx-1.5 flex h-8 flex-1 items-center justify-between rounded border bg-neutral-0 px-2 text-sm leading-none" | ||
| > | ||
| <span>${this.page?.url || "http://"}</span> |
There was a problem hiding this comment.
Suggested change
| <span>${this.page?.url || "http://"}</span> | |
| <span class="flex-1 truncate">${this.page?.url || "http://"}</span> |
There was a problem hiding this comment.
Do we want to truncate the URL if it's how the current page is identified? Maybe have it scrollable instead?
There was a problem hiding this comment.
Hmm, that's a good point — should it be focusable, and switch to being scrollable when it's focused?
There was a problem hiding this comment.
Also should've noted that we'll probably revisit the location bar anyway in the subtasks, this is to add one as a starting point.
| @@ -118,43 +156,144 @@ export class ArchivedItemQA extends TailwindElement { | |||
| <h1>${msg("Review")} — ${itemName}</h1> | |||
| </header> | |||
| <section class="main outline"> | |||
There was a problem hiding this comment.
Suggested change
| <section class="main outline"> | |
| <section class="main min-w-0 outline"> |
Adds button group to QA review page for approving, rejecting, and adding comments to a page. --------- Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
SuaYoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1477
Changes
You can access this view by adding
/review/screenshotsto a crawl detail page URL. The page IDs on the side are clickable.Manual testing
Testing steps in #1534
Screenshots