Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trashcan Icon Color Cleanup #1591

Closed
1 task done
Shrinks99 opened this issue Mar 12, 2024 · 0 comments · Fixed by #1628
Closed
1 task done

Trashcan Icon Color Cleanup #1591

Shrinks99 opened this issue Mar 12, 2024 · 0 comments · Fixed by #1628
Assignees
@Shrinks99
Labels
front end Requires front end dev work

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Mar 12, 2024 •
edited
Loading

Context

In the app we use red to signify serious issues and destructive / deletion actions. The trash can icons in most of the app aren't red on hover — but they probably should be! Now that we can define this easily (as of #1576) these should all be icon buttons with label attributes (after a brief look, lots are not accessible!) and class="text-base hover:text-danger" applied.

Todo

  • Replace trashcan buttons with icons with icon buttons
    • Add label attributes
    • Make them all red on hover
@Shrinks99 Shrinks99 added the front end Requires front end dev work label Mar 12, 2024
@Shrinks99 Shrinks99 self-assigned this Mar 12, 2024
@Shrinks99 Shrinks99 mentioned this issue Mar 26, 2024
Merged
Shrinks99 added a commit that referenced this issue Mar 27, 2024
@Shrinks99 @SuaYoo
Frontend: icon-button Cleanup (#1628)
275f694 
Closes #1591

### Changes
- Converts one instance of a button with an icon in it to an `icon-button`
- Makes all the trashcan icon buttons have a red hover state
- Adds localization function & placeholder to upload dialog "Name" field
- Adds localization functions to some missing icon-button label
instances
- Adds a few missing icon button labels

Co-authored-by: sua yoo <sua@suayoo.com>
Co-authored-by: sua yoo <sua@webrecorder.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shrinks99 Shrinks99

Labels
front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Frontend: icon-button Cleanup webrecorder/browsertrix
1 participant
@Shrinks99