Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: icon-button Cleanup #1628

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Frontend: icon-button Cleanup #1628

merged 9 commits into from
Mar 27, 2024

Conversation

Shrinks99
Copy link
Member

@Shrinks99 Shrinks99 commented Mar 26, 2024

Closes #1591

Changes

  • Converts one instance of a button with an icon in it to an icon-button
  • Makes all the trashcan icon buttons have a red hover state
  • Adds localization function & placeholder to upload dialog "Name" field
  • Adds localization functions to some missing icon-button label instances
  • Adds a few missing icon button labels (doesn't touch anything in the QA interface but note that some are missing there too!)

Screenshots

Screenshot 2024-03-26 at 6 42 04 PM

@Shrinks99 Shrinks99 requested a review from SuaYoo March 26, 2024 22:43
@Shrinks99 Shrinks99 self-assigned this Mar 26, 2024
@Shrinks99 Shrinks99 marked this pull request as draft March 26, 2024 22:43
@Shrinks99 Shrinks99 changed the title Frontend: Trashcan Cleanup Frontend: icon-button Cleanup Mar 27, 2024
Copy link
Collaborator

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@Shrinks99 Shrinks99 marked this pull request as ready for review March 27, 2024 18:54
@Shrinks99 Shrinks99 merged commit 275f694 into main Mar 27, 2024
2 checks passed
@Shrinks99 Shrinks99 deleted the frontend-trashcan-cleanup branch March 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trashcan Icon Color Cleanup
2 participants