Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable query param routing #29

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Enable query param routing #29

merged 2 commits into from
Nov 25, 2021

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Nov 24, 2021 •
edited
Loading

Changes:

  • enable query param when parsing routes (e.g. /verify?token)
  • refactor to remove leading _ in view state property keys

Implemented for #27

Manual testing

Run app and click around to navigate. Navigation should still work as expected.

@SuaYoo SuaYoo requested a review from ikreymer November 24, 2021 20:09
@SuaYoo SuaYoo self-assigned this Nov 24, 2021
This was referenced Nov 24, 2021
Merged
Merged
@ikreymer ikreymer merged commit 911dc64 into main Nov 25, 2021
@SuaYoo SuaYoo deleted the frontend-path-query branch November 27, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer Awaiting requested review from ikreymer

Assignees

@SuaYoo SuaYoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuaYoo @ikreymer