Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saving config limit and browser setting fields #704

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix saving config limit and browser setting fields #704

merged 1 commit into from
Mar 15, 2023

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Mar 13, 2023 •
edited
Loading

Fixes #689 (limits) and fixes #694 (browser settings)

Manual testing

  1. Log in and go to Workflow detail view
  2. Click "Edit Workflow" -> "Limits"
  3. Update fields and verify the following:
  • Max Pages value can be set and unset (i.e. value removed)
  • Crawl Time Limit value can be set and unset
  • Crawler Instances value can be saved
  1. Click "Browser Settings" and verify the following:
  • Block ads can be toggled and saved
  • Language can be changed and saved

@SuaYoo SuaYoo changed the title Fix saving config limit fields Fix saving config limit and browser setting fields Mar 13, 2023
Shrinks99
Shrinks99 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

stavares843
stavares843 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 💥

@ikreymer ikreymer merged commit 0009ce8 into main Mar 15, 2023
@ikreymer ikreymer deleted the frontend-fix-crawl-limits branch March 15, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@Shrinks99 Shrinks99 Shrinks99 approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SuaYoo @ikreymer @Shrinks99 @stavares843