Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.yaml UI option to disable printing from replay banner #815

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

tw4l
Copy link
Contributor

@tw4l tw4l commented Feb 15, 2023

Description

This PR adds a ui.disable_printing option to config.yaml which if set to any value with hide the new print replay iframe content button in the pywb 2.8 replay banner.

The second commit in this PR also modifies the VueUI.main() constructor to accept a JSON config object, to make the code a bit more readable and ease the addition of any future config options.

Motivation and Context

Commit 98be48d adds a print button the replay banner but in some deployments (e.g. reading rooms) pywb administrators may want to disable this option.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l requested a review from ikreymer February 15, 2023 21:55
@tw4l tw4l merged commit 83b2113 into main Mar 27, 2023
@tw4l tw4l deleted the disable-printing branch March 27, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant