Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Replay Bug]: When I open a specific archive, the software becomes unresponsive and turns white #330

Closed
cpqcat opened this issue Jun 12, 2024 · 1 comment · Fixed by webrecorder/wombat#146
Closed

[Replay Bug]: When I open a specific archive, the software becomes unresponsive and turns white #330

cpqcat opened this issue Jun 12, 2024 · 1 comment · Fixed by webrecorder/wombat#146
Labels
bug Something isn't working replay bug Archived content is not displaying as expected

Comments

@cpqcat
Copy link

cpqcat commented Jun 12, 2024

ReplayWeb.page Version

v1.8.17

What did you expect to happen? What happened instead?

It should be that When I open the archive, the webpage should be accessible and operable.
But when I open a specific archive, the software becomes unresponsive and then turns white

web archive and picture :
teramind2.zip
unresponsive picture:
unresponse
white page picture:
white_page

origin website: https://democompany.teramind.co/#/report/Focus+Dashboard

Step-by-step reproduction instructions

No response

Additional details

No response
@cpqcat cpqcat added bug Something isn't working replay bug Archived content is not displaying as expected labels Jun 12, 2024
@ikreymer
Copy link
Member

Appears to be an issue that can be fixed via wombat, will be in 2.0.2 release.

ikreymer added a commit to webrecorder/wombat that referenced this issue Jun 17, 2024
@ikreymer
rewriting fixes:
d7ac675 
- use Reflect.set / Reflect.get for doc proxy overrides (fixes document.head assign error on http://datagenetics.com/blog/july12019/index.html, webrecorder/archiveweb.page#195)
- better override for window.frames - resolves to window, so override numeric property on 'window' to fetch frames and add wombat override
- document.querySelector() override, rewrite 'src^=https?', 'href^=https?' query matches to instead be 'src*=' / 'href*=' to match rewritten URLs (fixes shorthand.com sites, eg: https://www.cambridge.org/news-and-insights/five-books-on-climate-action-for-cop28, webrecorder/replayweb.page#272)
- uses wombat.URL instead of window.URL to avoid infinite loop when window.URL is replaced with custom function (fixes webrecorder/replayweb.page#330)
- for document.write override, still assign even in SW to avoid synchronous code failing when expecting written HTML to be there, then still load from blob URL (fixes webrecorder/replayweb.page#332)
- don't intercept assign to '.search' / '.port', as those aren't being rewritten
- check if 'WB_wombat_' is in string before doing regex rewrite, speed up rewrite of very large string
ikreymer added a commit to webrecorder/wombat that referenced this issue Jun 17, 2024
@ikreymer
rewrite: uses wombat.URL instead of window.URL to avoid infinite loop…
c376989 
… when window.URL is replaced with custom function (fixes webrecorder/replayweb.page#330)
@ikreymer ikreymer mentioned this issue Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working replay bug Archived content is not displaying as expected
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rewrite: uses wombat.URL instead of window.URL to avoid infinite loop… webrecorder/wombat
2 participants
@ikreymer @cpqcat