Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show snapshot timestamp in location bar #228

Merged
merged 13 commits into from
Sep 7, 2023
Merged

Show snapshot timestamp in location bar #228

merged 13 commits into from
Sep 7, 2023

Conversation

SuaYoo
Copy link
Contributor

@SuaYoo SuaYoo commented Aug 30, 2023 •
edited

Resolves #210

Changes

  • Shows how many snapshots are available per page in URL bar
  • Allows users to navigate through snapshots through timestamp dropdown
  • Refactors coll.js and pageutils to typescript

Testing

  1. Generate wacz with multiple timestamps by using the AWP and navigating to the same page at different times.
  2. Load wacz and click page with multiple timestamps. Verify timestamps are shown in URL bar
  3. Click timestamp in URL bar. Verify timestamp options are shown
  4. Click option. Verify RWP loads with new timestamp
  5. Click page with single snapshot Verify timestamp is still shown

Screenshots

Location bar:
Screenshot 2023-08-30 at 12 52 56 PM

Snapshot dropdown:
Screenshot 2023-08-30 at 12 53 00 PM

@SuaYoo SuaYoo changed the title Show snapshot timestamp in URL bar Show snapshot timestamp in location bar Aug 30, 2023
@SuaYoo SuaYoo marked this pull request as ready for review August 30, 2023 21:22
Chickensoupwithrice
Chickensoupwithrice approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@Chickensoupwithrice Chickensoupwithrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with my WACZs and works as described. Learnt a lot reading this PR! :)

@SuaYoo SuaYoo mentioned this pull request Sep 5, 2023
Closed
23 tasks
@SuaYoo SuaYoo linked an issue Sep 7, 2023 that may be closed by this pull request
Show URL/location grouped by timestamp #210
Closed
@ikreymer ikreymer merged commit 79d2f15 into dev-2.0.0 Sep 7, 2023
4 checks passed
@ikreymer ikreymer deleted the multi-timestamp branch September 7, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@Chickensoupwithrice Chickensoupwithrice Chickensoupwithrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show URL/location grouped by timestamp
3 participants
@SuaYoo @ikreymer @Chickensoupwithrice