Convert URL encoded images to inline SVGs with fa-icon #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinks99
reviewed
Apr 9, 2024
At some point these got changed but the icons are remaining at the root directory.
- Removes span element - Adds aria-label to link to describe it - Makes the logo invisible to screen readers Tested with Voiceover
- Updates aria labels with improved descriptions Tested in Voiceover
Shrinks99
changed the title
|
Fixed the rest of them, added a few accessibility changes for better & quicker navigation of these images. Some are hidden, others are given discrete labels based on the context
|
Shrinks99
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid data: URL loading and just inject SVG inline