wacz replay: fix redirect loop, use different var for foundHash vs

existing hash to avoid redirecting to the same URL fixes webrecorder/replayweb.page#184
webrecorder · Jun 20, 2023 · 3e10dc4 · 3e10dc4
1 parent 702a609
commit 3e10dc4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/dist/sw.js b/dist/sw.js
diff --git a/src/wacz/multiwacz.js b/src/wacz/multiwacz.js
@@ -747,6 +747,8 @@ export class MultiWACZ extends OnDemandPayloadArchiveDB// implements WACZLoadSou
       return resp;
     }
 
+    let foundHash = null;
+
     for (const [name, file] of Object.entries(this.waczfiles)) {
       if (file.fileType !== WACZ_LEAF) {
         continue;
@@ -755,13 +757,13 @@ export class MultiWACZ extends OnDemandPayloadArchiveDB// implements WACZLoadSou
       resp = await super.getResource(request, prefix, event, {waczname: name, noFuzzyCheck: true});
       if (resp) {
         waczname = name;
-        hash = file.hash;
+        foundHash = file.hash;
         break;
       }
     }
 
     if (waczname) {   
-      return Response.redirect(`${prefix}:${hash}/${request.timestamp}mp_/${request.url}`);
+      return Response.redirect(`${prefix}:${foundHash}/${request.timestamp}mp_/${request.url}`);
     }
 
     if (this.fuzzyUrlRules.length) {