Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unarchived pages which have a Link on an archived HTML Page Result in multiple Self-Redirect (302) #184

Closed
ARiedijk opened this issue Jun 20, 2023 · 1 comment · Fixed by webrecorder/wabac.js#125
Closed

Unarchived pages which have a Link on an archived HTML Page Result in multiple Self-Redirect (302) #184

ARiedijk opened this issue Jun 20, 2023 · 1 comment · Fixed by webrecorder/wabac.js#125

Comments

@ARiedijk
Copy link

Replayweb.page version 1.7.14: Works normal behavior, players return error with tell: resource not in archive
Replayweb.page version 1.7.15: Fails, multiple retries, status 302?

Screenshot-network-tab

Given simple HTML in the archive:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Document</title>
</head>
<body>
    <a href="externalredirect.php">External redirect</a>
</body>
</html>

**When click on "External redirect" link **

Then
The 'Replayweb.player' Treats it as a Redirect Request - Check Out the Screenshot!
Expect
Notification: The Resource is Not Found in the Archive
waczfile-to-test.zip
ikreymer added a commit to webrecorder/wabac.js that referenced this issue Jun 20, 2023
@ikreymer
wacz replay: fix redirect loop, use different var for foundHash vs
3e10dc4 
existing hash to avoid redirecting to the same URL
fixes webrecorder/replayweb.page#184
@ikreymer
Copy link
Member

Thanks for the simple repro, fix is in wabac.js and will be in next release

@ikreymer ikreymer mentioned this issue Jun 20, 2023
Merged
ikreymer added a commit to webrecorder/wabac.js that referenced this issue Jun 20, 2023
@ikreymer
wacz replay: fix redirect loop on 404 (#125)
989082a 
* wacz replay: fix redirect loop, use different var for foundHash vs
existing hash to avoid redirecting to the same URL
fixes webrecorder/replayweb.page#184

* bump version to 2.16.2
@ikreymer ikreymer reopened this Jun 20, 2023
ikreymer added a commit that referenced this issue Jun 20, 2023
@ikreymer
fix redirect loop (fixes #184):
1d71a78 
- loading: fix redirect loop on 404s (via wabac.js 2.16.2)
- misc: additional check before autoupdate, update build deps to support Node 20
bump to 1.8.2
ikreymer added a commit that referenced this issue Jun 20, 2023
@ikreymer
fix redirect loop (fixes #184):
aca28de 
- loading: fix redirect loop on 404s (via wabac.js 2.16.2)
- misc: additional check before autoupdate, update build deps to support Node 20
bump to 1.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wacz replay: fix redirect loop on 404 webrecorder/wabac.js
2 participants
@ikreymer @ARiedijk