Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

Add initial e2e tests #2

Closed
wants to merge 1 commit into from

Conversation

littlebenlittle
Copy link

@littlebenlittle littlebenlittle commented Jan 20, 2021

This is a first crack at issue webrtc-rs/webrtc#42.

This is also my first crack at writing Rust, so I'm looking for feedback and suggestions. My code is almost certainly not idiomatic and I've probably made some simple mistakes with ownership, particularly across async calls.

See the tests README for general info.

See webrtc-rs/webrtc#47 for the original pull request

@metaclips
Copy link
Member

@littlebenlittle thanks for the pr, will be reviewing shortly.

@metaclips
Copy link
Member

@littlebenlittle this PR is bulky can this PR only Implement basic_e2e so we can sort out all issues?
Also, we should make all test files standalone if possible, structs and enums not needed across multiple files can be defined in a single file. We should do away with test_mod.rs if possible.
We also need to define integration tests in cargo.toml

[[test]]
name = "basic"

more here https://doc.rust-lang.org/cargo/reference/cargo-targets.html#tests

@metaclips
Copy link
Member

@littlebenlittle seem dtls::ConfigBuilder is not defined

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants