Reset counters so that the test can be run again for camresolutiontest.js #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed #145 |
| @@ -88,6 +88,9 @@ CamResolutionsTest.finishTestOrRetrigger = function() { | |||
| ' is not accessible or dead.'); | |||
| } | |||
| } | |||
| CamResolutionsTest.index = 0; | |||
| CamResolutionsTest.supported = 0; | |||
| CamResolutionsTest.unsupported = 0; | |||
There was a problem hiding this comment.
It makes more logic to initialize the variables at test start than to reset them at test end for the next run.
Can you move this to the test start? (i.e. CamResolutionsTest.camResolutionsTest)
Also once you have done so, you can remove the initialization on the main scope.
There was a problem hiding this comment.
Ofc, how silly of me, done!
andresusanopinto
added a commit
that referenced
this pull request
Oct 13, 2014
Reset counters so that the test can be run again for camresolutiontest.js. Fixes #145.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test is a run a second time it reuses the counters from the previous run effectively going out of bounds.