UI for audio mute, video mute, camera switch, fullscreen and hangup

[samdutton]

Uses inline SVGs to avoid slowing down page load. (These are well supported.)

Also added:
• $() function for document.querySelector()
• hide() and show() functions to add/remove the class name hidden
• activate() and deactivate() to do the same for active

Getting this error with jstdPhantom Grunt task, not sure why:

Safari: Reset
Safari: Reset
...
Total 3 tests (Passed: 3; Fails: 0; Errors: 0) (4.00 ms)
Safari 534.34 Mac OS: Run 4 tests (Passed: 3; Fails: 0; Errors 1) (4.00 ms)
error loading file: /test/js/main.js:60: TypeError: 'null' is not an object (evaluating 'muteAudioSvg.onclick = toggleAudioMute')

>> Total Passed: 3, Fails: 0

PhantomJS threw an error:
Done, without errors.

[juberti]

this should disappear now that we are using websockets

[samdutton]

Removed.

[juberti]

Looks solid, left a few comments. For future reference, please squash large commit sequences like this before sending a PR.

@jiayliu PTAL as well

[juberti]

this should probably point to apprtc.appspot.com/params.html, to avoid confusion

[samdutton]

Changed.

[samdutton]

New year's @juberti ping!

[juberti]

Keep the "powered by Google App Engine" thing here - this is a continual source of confusion

[samdutton]

Added in next commit.

[juberti]

At this point I just want to land this so we can avoid mergedowns against the other pending CLs. IOW I just want to check this in Friday; I will make any remaining fixes manually if needed.

[samdutton]

@juberti ptal

[juberti]

lgtm (still curious about how you solved the flipped-buttons problem)

[jiayliu]

One issue in main.js:

It calls isFullScreen, which is not defined anywhere.
https://github.com/GoogleChrome/webrtc/blob/master/samples/web/content/apprtc/js/main.js#L377

[samdutton]

The shim code was meant to be moved to util.js, but somehow I missed that.

Fixed in commit in github.com//pull/358.

On Mon, Jan 12, 2015 at 11:30 PM, Jiayang Liu notifications@github.com
wrote:

One issue in main.js:

It calls isFullScreen, which is not defined anywhere.

https://github.com/GoogleChrome/webrtc/blob/master/samples/web/content/apprtc/js/main.js#L377

—
Reply to this email directly or view it on GitHub
#311 (comment).