Add onItemHighlighted prop #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for updating other parts of the page in reaction to the highlighted item in the autocomplete dropdown being changed
|
Hey! Thank you so much for your PR! Here is the playground for this revision 🚀 I hope everything is fine! ❤️ This message has been generated automagically ✨ |
jukben
requested changes
Jun 22, 2020
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@webscopeio/react-textarea-autocomplete", | |||
| "version": "4.6.3", | |||
| "version": "4.7.0", | |||
There was a problem hiding this comment.
Can you please remove this change? I will do it during release process. I agree it should be 4.7.0 🙏
|
Alright, makes sense. I reverted it back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for updating other parts of the page in reaction to the highlighted item in the autocomplete dropdown being changed.
In my case I want to reference rows in a table by their name, and when a row's name is highlighted in the autocomplete dropdown I want to highlight the actual row. This PR aims to enable this functionality.
If the name
onItemHighlighteddoesn't make sense, let me know and we can find a better one, I'll update it.I also bumped the version to v4.7.0 (minor version bump) since this is more than just a bugfix. Again, I can revert this if you have another methodology to manage versions.