-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Cache Engine forces non-SSL scheme for XML Sitemap URL #715
Comments
@jaswsinc Any feedback here? You wrote this part of the code and I don't see any code comments indicating a reason |
I agree there is room for improvement here. The reason I'm forcing One way to improve this would be to force a scheme that matches their WordPress URL in the config options; i.e., Other Thoughts...This report of a problem also suggests there might be a problem with this method. It is configured to follow up to 5 redirects, which should be enough for the web server to tell us which scheme it prefers and for that test to succeed. However, this report suggests that method could be failing in some scenarios. In short, using
|
Not desirable in what way?
That seems like a pretty bad assumption, especially given the trend towards HTTPS everywhere. |
Right, but if a site owner has configured their |
Oh, I see.
Agreed. That makes a lot more sense. |
Cool.
Well, |
Next Release Changelog:
|
Comet Cache v160416 has been released and includes changes from this GitHub Issue. See the v160416 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#715). |
The Auto-Cache Engine forces an
http
scheme when building the Site URL for the sitemap that the Auto-Cache Engine uses:https://github.com/websharks/comet-cache-pro/blob/160227/src/includes/classes/AutoCache.php#L89-L95
It then uses that (forced
http
) URL when fetching the sitemap:https://github.com/websharks/comet-cache-pro/blob/160227/src/includes/classes/AutoCache.php#L100
This is likely to cause problems with sites that are HTTPS-only and which are using certain methods of enforcing HTTPS (e.g., certain SSL plugins or rewriting techniques). I'm not seeing any reason we should be forcing
http
here.Referencing internal ticket: https://websharks.zendesk.com/agent/tickets/11700
The text was updated successfully, but these errors were encountered: