Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: One-click Subscribe to Comments #178

Open
raamdev opened this issue Dec 13, 2015 · 11 comments
Open

Feature Request: One-click Subscribe to Comments #178

raamdev opened this issue Dec 13, 2015 · 11 comments

Comments

@raamdev
Copy link
Contributor

raamdev commented Dec 13, 2015

@jaswsinc writes in #108 (comment)...

Click Subscribe from a Post or Comment and not need to fill in anything. Great idea!

It would be nice if, for logged-in users, it were possible to one-click subscribe to all comments for a specific post, or to a specific comment.

@kristineds
Copy link
Contributor

@raamdev @jaswsinc If you could provide an outline for this, I can work on it. :)

@jaswrks
Copy link

jaswrks commented Jan 25, 2016

Somewhat related to this: #204

@jaswrks
Copy link

jaswrks commented Jan 25, 2016

Noting the $prefill parameter accepted by this class member already.
https://github.com/websharks/comment-mail-pro/blob/151224/comment-mail-pro/includes/classes/utils-url.php#L1393

@jaswrks
Copy link

jaswrks commented Jan 25, 2016

So once the work in #204 is complete, we will be mostly ready for this issue to be worked on. At present, the post_id is already passed through and prefilled automatically. However, the fname, lname, email are being improved and prepopulated in #204.

What remains after #204 is complete, is that we need some JavaScript that will automatically set the comment_id as well, and that will require JavaScript that can deal with nested comments in a thread, where the comment reply form is moved around into position based on which comment that a user is replying to.

@jaswrks
Copy link

jaswrks commented Jan 25, 2016

That JavaScript should go into this file and perhaps use setInterval() in order to get this integrated with WordPress core comment handling of the reply form.

var href = ''; // TODO
$('.cso-link-new > a').attr('href', href);
// $_REQUEST[__NAMESPACE__]['manage']['sub_form']['comment_id']

TODO: Write JavaScript for this after #204 is complete.

@jaswrks
Copy link

jaswrks commented Jan 25, 2016

@raamdev What does "one-click" mean to you exactly?

  • One-click, receive please confirm message?
  • Or, one-click and the subscribe form is completely prefilled. The user clicks a second time to subscribe.

@raamdev
Copy link
Contributor Author

raamdev commented Jan 25, 2016

@jaswsinc writes...

What does "one-click" mean to you exactly?

I was thinking there would be a one-click "Subscribe to All Comments" link on the Comment Form that would use JS to create a subscription, i.e., no confirmation message, no clicking a second time. The idea here is that since the user is already logged in (this is a logged-in user feature request) we already have all the information we need to subscribe them to the post. Why make them fill out a form? And if we don't need them to fill out a form, why bother with pre-filling the form and then asking them to click the subscribe button?

A single, plain-text link that says "Subscribe to All Comments" link would be nice. When clicked, it would subscribe the user to that post without reloading (i.e., via JS) and the "Subscribe to All Comments" link would then changed to "Subscribed! (undo)" with the 'undo' portion maybe linking to their My Subscriptions page where they can manage subscriptions...

@jaswrks
Copy link

jaswrks commented Jan 26, 2016

I was thinking there would be a one-click "Subscribe to All Comments" link on the Comment Form that would use JS to create a subscription, i.e., no confirmation message, no clicking a second time.

and the "Subscribe to All Comments" link would then changed to "Subscribed! (undo)" with the 'undo'

Cool. So just a message with something like, "Thanks! Please check your email to confirm.". Or, if there is no need to confirm them, just an undo link that they can click. I like it.


OK. Well, my feeling is that this is not necessary then.

Next Actions

An outline in this issue should be all about building a new JS component that will replace the existing static link found in the subscription options template. This idea that I suggested here could still be used as a non-JS fallback, but the following would be better:

I was thinking there would be a one-click "Subscribe to All Comments" link on the Comment Form that would use JS to create a subscription, i.e., no confirmation message, no clicking a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants