Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe Customer Object Missing Token #326

Closed
jaswrks opened this issue Sep 8, 2014 · 6 comments
Closed

Stripe Customer Object Missing Token #326

jaswrks opened this issue Sep 8, 2014 · 6 comments

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Sep 8, 2014

A site owner reports that some of their customers are missing a token on the customer object in their Stripe Dashboard. I have not been able to confirm this yet. Testing is needed.

In the original report that we received, a Stripe rep. mentions that s2Member is not sending a token through with the customer object creation. This is to be expected. s2Member adds the token in a second API call, where it adds the token to the customer object once it has been created. I don't see an issue with this, but again, further testing is needed here.

@jaswrks
Copy link
Contributor Author

jaswrks commented Sep 8, 2014

@jaswrks
Copy link
Contributor Author

jaswrks commented Sep 8, 2014

Initial tests complete. I've been unable to reproduce this issue so far. The card/token is added to the customer object in my tests. It almost sounds like the issue being reported could be attributed to an API call failure, for a reason that remains a mystery for the moment. Unable to reproduce that either so far.

2014-09-08_09-40-44

@jaswrks
Copy link
Contributor Author

jaswrks commented Sep 8, 2014

A site owner reports that it happens to them with a $0 value in the trial period. Testing this now.

@jaswrks
Copy link
Contributor Author

jaswrks commented Sep 8, 2014

Successfully reproduced this issue against a $0 initial amount in the Stripe Dashboard. Marking this issue as a priority item for the next release of s2Member Pro.

2014-09-08_12-08-29

@jaswrks jaswrks added this to the Next Release milestone Sep 8, 2014
@jaswrks jaswrks self-assigned this Sep 8, 2014
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Sep 8, 2014
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Sep 9, 2014
Bug fix; Stripe token on `0$` trial period. See: wpsharks/s2member#326
@jaswrks
Copy link
Contributor Author

jaswrks commented Sep 9, 2014

This has been resolved in the dev branch. This fix will go out with the next release, which is likely to occur sooner rather than later.

2014-09-08_16-06-53

@jaswrks jaswrks closed this as completed Sep 9, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Sep 9, 2014

Next release changelog:

  • (s2Member Pro) Stripe Bug Fix: This release corrects an issue with Stripe Pro Forms and a $0 trial period. A symptom of this bug was to find a customer's Stripe token value missing from their Customer object in the Stripe Dashboard. This issue impacted Pro Forms whenever a 100% free trial was offered (i.e. with a $0 sale amount). Resolved by this release. Please see this GitHub issue if you'd like the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant