v150225 - Broken Pagination still

[webxolutions]

Greetings! I recently updated the s2Member / Pro framework on my development setup via the WP plugins update page and discovered that the Pagination breaks. I followed the usual steps to find a fix and came across several pages, with the most recent being issue 155 on s2member github:
#155 (comment)

When I print_r the $pagination variable, I get this array:

Array (
    [1] => Array
        (
            [url] => 
            [text] => 1
            [link] => 1
        )
)

The shortcode will print the first 25 members but no pagination. I went and modified the shortcode to its simplest format and even switched to the default s2 member list template -- no fix.

Any suggestions to get the pagination query working again? Could this be a conflict with another plugin or is it the recent updates to s2Member? Thank you in advance!

[jaswrks]

@webxolutions Thanks for the report! Can you please confirm the version of s2Member Pro that you're running currently please?

[webxolutions]

Yes,
Version 150225 + s2Member Pro v150225

This is also a multisite setup, but I don't think that is related to the bug. Let me know if you need any other details of my installation.

[jaswrks]

@webxolutions Thank you. I'm going to make an attempt to reproduce this. Can you please copy/paste the [s2Member-List /] shortcode that you used where this was a problem? Just so I can make sure I have the same on my end when attempting to reproduce. Thanks!

[webxolutions]

Sure. As mentioned previously, this produces the same result whether or not I use any arguments on the shortcode. Here's what I use (with s2 custom fields):

[s2Member-List show_fields="Primary Chapter:primary_chapter,Business Name:business_name,Date Registered:user_registered,Business Type:business_type,Website:website_url,linkedin_url,twitter_url,googleplus_url,facebook_url,youtube_url" orderby="display_name" order="ASC" link_display_name="/blog/member/%%username%%" avatar_size="100" link_avatar="/blog/member/%%username%%" enable_list_search="yes" template="nhora-member-list.php"/]

Even when I try just this:

[s2Member-List /]

...and when I specify the default s2 member list template (copied to themes folder)

[jaswrks]

Thank you 👍

[jaswrks]

@webxolutions I can reproduce this also.

I've had this corrected in the development copy. It will get pushed out with the next release. Until then, you can download this updated file and let it overwrite your existing copy of /s2member-pro/includes/classes/members-list.inc.php

Please confirm that this corrects the issue for you. Thanks in advance! :-)

[jaswrks]

Next Release Changelog:

• (s2Member Pro) [s2Member-List /] Bug Fix: This release resolves an issue with pagination in the [s2Member-List /] shortcode after recent changes in the WP_User_Query class. See this GitHub issue if you'd like additional details.

[webxolutions]

YES! Thank you, it worked. Here's my screencap of my pagination...

[raamdev]

@webxolutions Thanks for the confirmation that the bug fix worked! :-) I'm closing this issue. This bug fix will go out with the next release of s2Member.

[webxolutions]

Thank YOU guys for the quick turn-around. Awesome support!