New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordPress 4.3.1 changed wp_new_user_notification() again, conflicting s2member v150827 #732
Comments
Thanks for the very detailed report. Really appreciate it! |
Hello, it seems the $deprecated argument is not the only issue. For a couple of hours I checked different solutions - without luck. I did reorder second and third argument in the pluggable.php - no succsess. And If S2 Member is working on that, please give back the posibility, that a wordpress generated password is send to a new user direct after registration! The new way with a link is a) not as save as before. B) It is definitly not user friendly and a mess if you want to earn money with your blog. Let me say, that is very very annoying, if hyperactiv wordpress-developer force users into changing their stable running system. The ours of testing and bug isolation, will nobody pay. I have to allowed New User that they can set their own password direct in the registration process and thats not more safe! |
I have successfully confirmed and reproduced @bridgeport's bug report as he described. Custom Passwords + WordPress defaults for New User Email Configuration = "Your username and password info" email being sent anyway with a "To set your password" link. Tested with WordPress v4.3.1 + s2Member Pro v150827 |
Thanks for working on it. |
Also reported here: https://websharks.zendesk.com/agent/tickets/8469 |
Also reported here: https://websharks.zendesk.com/agent/tickets/8443 |
Also reported here: https://websharks.zendesk.com/agent/tickets/8445 |
Next Release Changelog:
|
This has been fixed in the development copy. No short-term patch available for this I'm afraid. However, we will push this out ASAP. Pending internal testing only. Thanks @bridgeport! |
Also reported here: https://websharks.zendesk.com/agent/tickets/8509 |
So, in v150925, will the users be allowed to set a password during registeration and then then receive that password in plain text as e-mail like before or not? Please confirm this since I'm confused whether this is fixed or now. Thanks! |
This was resolved in 150925, yes.
No. If you enable Custom Passwords, the email is not sent, no matter what it contains. |
Alright, so will the e-mail still contain a link to "Create a Password"? I'm sorry asking these questions rather than updating the plugin myself, but I want to make sure before I update. |
@raajtram If Custom Passwords are enabled (i.e., users set their password on the Pro-Form when registering), then no email to set the password is sent (i.e., the New User Email Message is not sent). If Custom Passwords are disabled (i.e., users are not allowed to create a password on the Pro-Form when registering), then the standard WordPress email containing a link to set the password is sent after they register (or, if you've modified the New User Email Message in s2Member → General Options → Email Configuration, then that modified email will go out--just be sure to include So again, the behavior depends on the Custom Passwords setting. See s2Member → General Options → Registration/Profile Fields & Options → Allow Custom Passwords During Registration?. |
There are many of my clients who are complaining of issues after upgrading WordPress 4.3.1. |
The change in WordPress 4.3.1 wp_new_user_notification() pluggable function effectively undoes the fix in the latest s2member version, which was extensively discussed in issue #689
Settings to reproduce:
Following a checkout where a user chooses their own password, the following is emailed to the user:
Email subject:
Email body:
If a user is setting their own password upon registration, the above obviously shouldn't be sent.
The pluggable wp_new_user_notification() function arguments changed again, as documented here:
Passwords: Deprecate second parameter of wp_new_user_notification().
Version 4.3 function with two arguments:
Version 4.3.1 function with three arguments (middle argument deprecated):
I assume there's a possibility that WordPress will eventually remove the second
$deprecated
argument, which would reintroduce this issue, unless s2member were modified to expect the third$notify
argument to always be the last argument.Thanks.
The text was updated successfully, but these errors were encountered: