Made tests cross platform #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var safeFileName = urlPath.replace(/\.\./g, '.'); | ||
| safeFileName = path.normalize(safeFileName); | ||
| return safeFileName; | ||
| return urlPath.substring(1).replace(/\.\./g, '.'); |
There was a problem hiding this comment.
We use urlPath which is the absolute path on the website, e.g.: /some/path/something.html. We want a relative path as a result, that is why we use .substring(1) to cut off the starting /.
|
Thanks @marklagendijk
And need to add CI for windows. I'm going to do it in #84 |
|
I indeed only updated failing tests. Will take a look at the ones I missed. |
| // if it replaces them we receive 'some/path/../../../../etc/passwd' | ||
| // path.resolve('some/path/../../../../etc/passwd'); = '/etc/passwd' => which is not safe | ||
| var r = new Resource('http://example.com/some/path/.../.../.../.../etc/passwd'); | ||
| bySiteStructureFilenameGenerator(r, options).should.equalFileSystemPath('some/path/.../.../.../.../etc/passwd'); |
There was a problem hiding this comment.
@marklagendijk need to think how to handle this. Because not it replaces ... => .. which makes code unsafe
we can:
- create directories with names
...(as in test) - or cut that pieces
what do you think about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.