Correctly deletes events in javascript queue when they have been processed fixes #274 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode. Correctly update the dispatcher queue whenever an event is finished.
|
Working on the spec |
|
Fixes #274 |
… no way of skipping the callback
|
+1 |
1 similar comment
|
👍 |
shllg
added a commit
to wonderweblabs/websocket-rails
that referenced
this pull request
Jan 22, 2015
Correctly deletes events in javascript queue when they have been processed fixes websocket-rails#274 websocket-rails#278
…bscribe_private fixes websocket-rails#265
…'s already private fixes websocket-rails#280
Rare bug where Synchronization#synchronize! was being called again before the initial setup was complete. This resulted in multiple event listeners being created and duplicate events triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javascript queue is now correctly updated and a new configuration config.trigger_success_by_default (Boolean, defaults to true) exists. A result is triggered for each event, and the default result is success.