Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for prebuild to build for all abi version of node/iojs #11

Closed
wants to merge 1 commit into from
Closed

Conversation

ralphtheninja
Copy link

prebuild-utf-8-validate

While I was at it, I created this PR as well since ws use this native module as well as bufferutil, see websockets/bufferutil#12

@kleetus
Copy link

kleetus commented Oct 15, 2015

It would great if we can get this merged.

@paulirish
Copy link

this would help me out massively

@ralphtheninja
Copy link
Author

If you decide to take it, we should update list of abi's as well, since both node 4 and 5 was released after this PR was made. See leveldown.

@ralphtheninja
Copy link
Author

Updated PR to do prebuild --install rather than prebuild --download. And also changed prebuild npm script to do prebuild --all --strip, which builds for all abi versions.

I noticed bitpay added it to their fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants